Design comparison
SolutionDesign
Solution retrospective
Please provide your valuable feedback on my project. Specifically, I would like to know the following:
- How is the overall look and feel of the project?
- Is the content clear and easy to understand?
- Are there any suggestions you have for improving the card design or user experience?
- Are there any areas of the project where you experienced difficulty or confusion?
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers
- For example:
- The
<main>
element should include all content directly related to the page's main idea, so there should only be one per page - The
<footer>
typically contains information about the author of the section, copyright data or links to related documents.
- The
- So resolve the issue by replacing the
<div class="orderCard">
element with the proper semantic element<main>
in yourindex.html
file to improve accessibility and organization of your page
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1 - @pperdanaPosted over 1 year ago
Hello thereπ!! Congratulations on completing this challange.
- I have some additional recommendations for your code that I think you'll find interesting and valuable.
π Image element do not have
alt
attributes or you leave it blankfor example code
<img src="images/image-qr-code.png">
In this code you should add
alt
in your code<img src="images/image-qr-code.png" alt="qr code" >
- This
alt
attribute provides alternative text for images, which is important for accessibility purposes. Screen readers, use the alt attribute to read out loud what the image is about, allowing visually impaired users to understand the content of the page.
I hope you found this helpful! π
Happy codingπ€
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord