@ericsalvi
Posted
Hey Maia,
Great job with your first submission!!! I like how you structured your layout on the submission. The class names make sense and the different sections that make up this component are easy to understand. Also thank you for the call-out in your repository!
A few things I would suggest either fixing now or remembering to keep an eye out for future submissions is to fix any accessibility or HTML issues.
https://www.frontendmentor.io/solutions/responsive-order-summary-card-LpTS2rYbNT/report
Something I like to do also is to make sure to remove any HTML commented-out sections or unnecessary CSS.
The last thing I noticed is that your background image does not span the entire body width. You could easily add background-size: 100% to the body selector to fix this.
Cannot wait to see future submissions by you!
@maiaflow
Posted
@ericsalvi thank you! i forgot to validate my HTML before submitting but will do that next time. some helpful tips in there for sure, like i didn't know Headers are supposed to only go down 1 level at a time. and thank you for the call out about background size! gotta test all browser sizes
@ericsalvi
Posted
@maiaflow axe DevTools is a great Chrome extension that I'd suggest using before you submit. This can help find any accessibility issues before you submit. Color contrast is one thing that may be a bit challenging to fix given the original design.
Marked as helpful
