Skip to content
Submitted over 1 year ago

Responsive Order Summary

Ferdi Tondeur•100
@ferditondeur
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Tried not using fixed widths and heights as much. Still need to figure out the best use-cases for both flex and grid in these types of designs. Seems a combination worked for now. Was there a more efficient way I overlooked?

The top image had some overflow issues I couldn't seem to fix except for (in my opinion) bruteforcing it with a 'overflow: hidden' on the parent, which doesn't seem ideal.

I still feel like I design these things in a more roundabout way than necessary, so if anyone could share any insights, that would be great!

Community feedback

  • Vanza Setia•27,775
    @vanzasetiaPosted over 1 year ago

    Hi, Ferdi Tondeur! 👋

    In general, you should use flexbox for one direction layout either column or row. You should use the grid for two dimensions layout. Meaning, the layout requires the column and the row to be controlled.

    In this case, you make the <body> element as a flex container to put the card in the middle of the page.

    For the <main> element or the card element, you only need to set a max-width to prevent it from filling the entire page on large screen sizes. So, you should remove min-width, min-height, and max-height.

    For the height of the card, let the content controls the height of it.

    For the illustration image, it will be overflowing because the <span> is larger than the parent element—the <main> element—because of the border-radius. You are already doing great by setting overflow: hidden on the parent element.

    But, I recommend making the illustration a "real" image element. This way, you don't have to set height and other background properties. In other words, you will end up with less code.

    Also, you should rarely set any width or height. That does not mean you are using dynamic units such as percentages or viewport units, you can use them very often. I think the golden rule of responsive design is to let the content controls the size of the element whenever possible.

    I hope this helps. Happy coding! 😄

    Marked as helpful
    0
  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HEIGHT 📐:

    • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.
    • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.
    • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord