Responsive order page using Flexbox

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @tossik8, Congratulations on completing this challenge!

  One tip about alignment best practices:

  The approach you've used to center this card vertically is not the best way, because using margins you don't have much control over the component when it scales. My suggestion is that you do this alignment with flexbox using the body as a reference for the container.

  Remove the margins

  body main {
      background-color: hsl(0deg, 0%, 100%);
      width: 26.33vw;
      margin: 0 auto;
      /* margin-top: 8rem; */
      border-radius: 20px;
      text-align: center;
  }
  

  The first thing you need to do is to remove the margins used to align it, then apply min-height: 100vh to the body to make the child (the card/container) align to its size that now will be displaying 100% of the viewport height and then give its alignment with display: flex and align-items: center / justify-items: center.If you're using the attribution you need to add flex-direction: column to make the attribution stays under the QR Code component. See the code below:

  body {
      min-height: 100vh;
      margin: 0;
      font-family: "Red Hat Display", sans-serif;
      background: url(../images/pattern-background-desktop.svg) no-repeat;
      background-size: contain;
      background-color: hsl(225deg, 100%, 94%);
      display: flex;
      align-items: center;
      justify-content: center;
      flex-direction: column;
  }
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Nikita Toropov•310

  @tossik8Posted about 2 years ago

  Hello @correlucas, Thank you for the advice, I've changed the code as you suggested. I haven't thought of this approach before and it is much much better. Thank you and happy coding!

  0