Submitted almost 3 years ago
Responsive Order Card Summary Component
@abishekbardewa
Design comparison
SolutionDesign
Community feedback
- @anoshaahmedPosted almost 3 years ago
Hey good job on this challenge! Your report above shows a few issues. You can fix them by
- wrap everything in your body in
<main>
... OR use semantic tags! .... you can also giverole=""
to the direct children of your<body>
but that's a little frowned upon... Read more here - have at least one
<h1>
in your code - start your headings with
<h1>
, and move up by one level each time
Hope this helps :)
Marked as helpful0@abishekbardewaPosted almost 3 years ago@anoshaahmed Thanks for the review, I just have few doubts hope you clarify it. Do I specifically need to use h1 tag first or I can use other h tags and what about font size I did not use h1 cause it was way bigger than required that is why I use h2 there and I have also use h4 for Annual Plan heading, is it ok or I need to change that too.
0@anoshaahmedPosted almost 3 years ago@abishekbardewa Yes, start with h1, then move on to h2. You can change the font size yourself.
Check out my repo about this topic here
Marked as helpful0 - wrap everything in your body in
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord