@DylandeBruijn
Posted
@Rokeeb01Maruf
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
I suggest using clear descriptive CSS classes like
.card
,.card-title
and.card-description
. -
Try using semantic HTML elements like
main
,section
andarticle
. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
You donβt have to wrap your image in a separate
div
, itβs possible to style it directly to achieve the same result. -
Try making your solution more responsive.
-
Try using the right semantically right HTML tags, like
h1
orh2
for the title of your recipe.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
@Rokeeb01Maruf
Posted
Thank you very much for the feedback, I will try and correct my mistakes.β€οΈ @DylandeBruijn
@Rokeeb01Maruf
Posted
Thanks you very much, I will try to apply the feedback to it. Thank you very much.β€οΈ@DylandeBruijn