Skip to content
Submitted about 1 month ago

Responsive Omelette Recipe

Andymiguel25ā€¢80
@Andymiguel25
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Recipe page
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Adrianoā€¢38,270
    @AdrianoEscarabotePosted about 1 month ago

    Hi Andymiguel25, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:

    Consider using rem for font sizes. When font sizes are set in absolute units like pixels, users can't adjust the text size based on their preferences. Relative units like rem adapt to the screen size and user settings, making them more flexible across various devices.

    If you'd rather keep using px, you can download a handy VS Code extension that converts pixels to rem automatically

    link -> px to rem

    We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements.

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    The rest is excellent.

    I hope you find it useful. šŸ‘

    Marked as helpful
    0
  • Khrystyna Horbenkoā€¢230
    @KristinaHorbenkoPosted about 1 month ago

    "This code is too simple and requires improvements to ensure correct functionality across different screens. One of the main drawbacks is the lack of media queries for adapting styles to various devices. In its current state, the page will not display properly on mobile devices, as the element sizes are statically defined without considering the screen width.

    Additionally, it's worth noting the design inconsistencies. For instance, the use of inline styles for headings and text reduces flexibility and creates challenges for future style modifications. The font is chosen arbitrarily, and in the mobile version, it does not scale according to the screen size, making the text hard to read on smaller displays.

    To enhance this code, I would add media queries to properly adapt elements for different screen sizes. Improving typography and the overall structure of the styles would also make them more universal and supportive of scaling."

    Marked as helpful
    0
  • Andymiguel25ā€¢80
    @Andymiguel25Posted about 1 month ago

    Thank you so much

    0
  • Andymiguel25ā€¢80
    @Andymiguel25Posted about 1 month ago

    Thank you for your feedback. The layout is always responsive, but whenever I update it on Frontend Mentor, it becomes unresponsive. Iā€™m not sure why this happens.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord