Design comparison
Solution retrospective
I used tailwindcss for css, what do you think of styling? This in my first React app, what do you think of structure and all about state? I know react structure, components and passing props are not in the best possible way. I was just exited to deploy what I achieved so there are bad practices in my code, please let me know which and what is good practice to replace that with it.
Thank you
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports due to
non-semanticmarkup, which lack landmark for a webpage
- So fix it by replacing the element
<div id="root">the with semantic element<main>in yourindex.htmlfile to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>or<span>
- They convey the structure of your page. For example, the
<main>element should include all content directly related to the page's main idea, so there should only be one per page
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0@eng-milanPosted over 1 year ago@0xAbdulKhalid Thanks for taking your time leaving this comment for me. you are right, I'll fix it. Finally I appreciate your positive review of my app. This will push me to do better.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord