Design comparison
Community feedback
- @correlucasPosted about 2 years ago
πΎHello @Zer0-07, Congratulations on completing this challenge!
Great code and great solution! Iβve few suggestions for you that you can consider adding to your code:
The value youβve used for the shadow make it too much dark and strong. To improve your box-shadow, youβve to have in mind two things that make a good shadow,
blur
andlow opacity
for smooth shadows. To improve your current shadow, decrease theopacity
and increase theblur
, try this value instead:box-shadow: 12px 7px 20px 6px rgb(57 75 84 / 8%);
If youβre not familiar to box-shadow you can use this site to create the shadow design and then just drop the code into the CSS: https://html-css-js.com/css/generator/box-shadow/
βοΈ I hope this helps you and happy coding!
Marked as helpful1@Zer0-07Posted about 2 years ago@correlucas Thank you so much for your suggestions. I will try to improve it.
0 - @denieldenPosted about 2 years ago
Hello Abdul, You have done a good work! π
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - remove
max-width
fromcontainer
class - you can fix the effect
:hover
creating adiv
that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution - use
min-height: 100vh
tocontainer
class instead ofheight
, otherwise the content is cut off when the browser height is less than the content - add
transition
on the element with hover effect
Keep learning how to code with your amazing solutions to challenges.
Hope this help π and Happy coding!
Marked as helpful1@Zer0-07Posted about 2 years ago@denielden Thank you so much for your quick suggestions! I am gonna fix it up. Really appreciate it. I am still learning.π
1@Zer0-07Posted about 2 years ago@denielden I had question.. How did you add "Cyan" color on image hover?
1@denieldenPosted about 2 years ago@Zer0-07 simple, I assigned it to the hover state of the
div
as you can see in my solution :)Marked as helpful1@Zer0-07Posted about 2 years ago@denielden thanks but which property should i use in pure css? I am not using tailwind..
1@denieldenPosted about 2 years ago@Zer0-07 :hover to the div
https://developer.mozilla.org/en-US/docs/Web/CSS/:hover?retiredLocale=it
Marked as helpful1@denieldenPosted about 2 years ago@Zer0-07
backgorund-color: rgba()
Marked as helpful0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord