Responsive NFT preview

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @Torawijaya, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  To improve your component overall responsiveness, something you can do its to create a media query to save space in the pricing section to make each information in a different row. Here’s the code for this media query.

  @media (max-width: 350px) {
  .nest {
      display: flex;
      flex-direction: column;
      justify-content: space-between;
      margin-bottom: 20px;
      align-items: center;
  }
  }
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Tora Wijaya•170

  @Mirare23Posted about 2 years ago

  @correlucas Thanks lucas.

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hello , You have done a good work! 😁

  Some little tips to improve your code:

  • use main tag to wrap the card and improve the Accessibility but not as a container of that one element
  • also you can use article or div tag instead of main to the container card for improve the Accessibility
  • You can fix the effect :hover creating a div that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution
  • Using <hr> for the line is not the best way because this tag have a semantic meaning... in this case use div with border-bottom because this line is decorative
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0

  ---

  

  Tora Wijaya•170

  @Mirare23Posted about 2 years ago

  @denielden Thanks deniel, it helps a lot. Gonna use it for the further challange

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @Torawijaya you are welcome and keep it up :)

  0