Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive NFT Preview Card Component using SASS

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I enjoyed working on this. Would love feedback on best practices as always. Thank you.

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • The NFT Alt Tag description needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.

  • The Icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • Wrap the "NFT image", "Equilibrium #3429" and "Jules Wyvern" in an Anchor Tags <a>. The anchor tag will allow users to click on content and have them directed to another part of your site.

If you have any questions or need further clarification, let me know.

Happy Coding! 👻🎃

Marked as helpful

0

@mbonamensa

Posted

@vcarames Thank you for pointing these out. I think another alternative for the icons will be to use svg instead of img to get rid of the alt text altogether. What do you think?

0

@VCarames

Posted

@mbonamensa

That’s correct!

You can use the ‘Background-image’ property.

Personally I don’t like implementing icons as ‘svg’ since it adds a lot of code for one simple icon. But that’s just my preference. The alternative you offered, is definitely acceptable.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord