Responsive nft preview card component using HTML and CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • The another reason why your component is not being placed on center is the incorrect usage of width and height, You want to use min-height: 100vh. Since you already using Flexbox layout in css, So take a look the example code

  ---

  body {
  min-height: 100vh;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  body {
  margin: 0 auto;
  margin-top: 20vh;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  • For proper positioning of nft eye(view-icon) delete the commented line and replace transform with the below code

  .img-overlay img {
  position: absolute;
  /* left: 65px; */
  /* top: 50px; */
  transform: translate(7.5rem,7.5rem);
  }
  

  I hope you find this helpful.

  Happy coding😄

  0