Responsive NFT preview card component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Bachar_elkarni,

  Congratulation on completing another frontend mentor challenge. Excellent work! I have some suggestions regarding your solution:

  • Why did you use <section> in this challenge the way you did? According to MDN , <section> is a generic sectioning element that is used whenever it doesn’t make sense to use the other more semantic ones.** It is a container that stores self-contained content that still makes sense when placed in a different context.**If you are only using the element as a styling wrapper, use a <div>. In this challenge, it’s all one component.

  • The most important part in this challenge is the interactive element. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ...) For this imagine what would happen when you click on the image, there are two possible ways:

  1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>.

  2:If clicking the image would navigate the user to another page to see the NFT, here use <a>.

  • You should have used <a>to wrap Equilibrium #3429 and Jules Wyvern too.

  • Page should contain one level heading. To tackle the accessibility issue in this challenge, you can use <h1> for Equilibrium #3429, as you should use a heard not a <p>.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock).

  • The link wrapping the equilibrium image (image-equilibrium) should either have Sr-only text, an aria-label that indicates where the link navigate the user(not describes the image).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be photo of the creator. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • There are so many ways to add the hover effect on the image , The one I would use, using pseudo-elements to change the teal bg color to a hsla. Then opacity can be changed from 0 to 1 on the pseudo element on hover. There is no need for a extra clutter in the HTML. The icon view does not really need to be in the HTML. You can use CSS for it.

  Hopefully this feedback feedback helps.

  Marked as helpful

  1

  ---

  

  Bachar_elkarni•160

  @Diamo-BPosted about 2 years ago

  @PhoenixDev22 I'm really speechless, this was really helpful thank you so much man, I'm going to fix these issues as good as I can then I'll commit it to the repo. Thank you so much again for the time you spent on this, I really appreciate it

  0

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @Diamo-B

  Glad to hear that it was helpful. Happy coding!

  1