Design comparison
SolutionDesign
Solution retrospective
As a bonus to this challenge, I made the image popup on click of the main image.
Community feedback
- @denieldenPosted over 2 years ago
Hi Joshua, very great work! 😉
Using
<hr>
for the line is not the best way because this tag have a semantic meaning... in this case use div withborder-bottom
because this line is decorative.Also instead of using
px
use relative units of measurement likerem
-> read hereHope this help! 😁
Marked as helpful1@dyntbnPosted over 2 years ago@denielden
Reading about the
<hr>
on MDN docs, I see now that it did not fit semantically. I will fix that and see what I can do to minimize my use ofpx
units.Thanks for pointing these out Deniel! 🙂
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord