Travolgi 🍕• 31,420
@denielden
Posted
Hi Joshua, very great work! 😉
Using <hr> for the line is not the best way because this tag have a semantic meaning... in this case use div with border-bottom because this line is decorative.
Also instead of using px use relative units of measurement like rem -> read here
Hope this help! 😁
Marked as helpful
1
Joshua• 130
@dyntbn
Posted
@denielden
Reading about the <hr> on MDN docs, I see now that it did not fit semantically. I will fix that and see what I can do to minimize my use of px units.
Thanks for pointing these out Deniel! 🙂
1
