Responsive NFT card preview.

Community feedback

• 

  Karishma Garg•1,010

  @karishma-devPosted over 2 years ago

  Hey, your solution looks good. Few suggestions:

  1. Make your container as the main tag instead of div, this should help you solve your accessibility issues.
  2. And for the alignment of elements issue that you are facing, I used flex in my solution. Add flex in your left and right class, and also the class that contains both of these classes.

  Hope this helps you!

  Marked as helpful

  0
• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Lets firstly work on your accessibility issues.

  • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="container"> instead of <div class="container">.
  • Page should contain a level-one heading basically means your html should have a h1 it aid navigation hence <p >Out Equilibrium collection promotes balance and calm </p> should be <h1>Out Equilibrium collection promotes balance and calm</h1> and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

  This should fix most of your accessibility issues.

  • You can maybe increase the font size of your a tag and pad out some of your items.

  . Regardless you did amazing... hope you find this helpful... Happy coding!!!

  Marked as helpful

  0
• 

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 2 years ago

  Hey Adil, Congrats on completing your first ever frontend mentor challenge. It looks pretty sharp too! Here's a few tips:

  • First off, to answer your question, you might want to wrap the clock icon and it's text in a div and apply the following properties to the div (let's give it a class of "clock-div" I am not good with names):

  .clock-div {
      display: flex;
      align-items: center;
      gap: 10px;
  }
  

  It's the align-items: center property that does the magic!

  • You also need to place landmarks in your html code so that it's well structured and easily navigated by the browser This will fix your accessibility issues. follow this link to learn more about landmarks and how to use them. Happy Coding!

  Marked as helpful

  0