@PhoenixDev22
Posted
Hello @Anq92,
I have some suggestions regarding your solution:
-
For any decorative images, each img tag should have empty
alt=""
*as you did**andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images in(icon-view, icon-ethereum, icon-clock
). -
I would use pseudo-elements to change the teal bg color to a hsla. Then opacity can be changed from 0 to 1 on the pseudo element on hover as there is no reason to have the extra clutter in the html.
-
The avatar's alt shouldn't be
empty
, you can useJules Wyvern
for it. -
the link should be wrapping the main image and either have
Sr-only
text, anaria-label
oralt
text that says where that link takes you. -
So you can use
<ul>
to wrapclass="counter"
and in each<li>
there would be<img >
and <p>`` . -
No need for
<hr>
, you can useborder-top
to theclass="author "
. -
For the avatar's part , you can use
<figcaption >
and<figure>
.
Overall, your solution is good, Hopefully this feedback helps.
Marked as helpful