Responsive NFT Card

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Christian, good job! I took some time to look at your code and have some ideas for improving it:

  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • using <hr> for the line is not the best way because this tag have a semantic meaning... in this case use div with border-bottom because this line is decorative
  • for the author name use a tag instead span element

  Overall you did well 😉

  Hope this help and happy coding!

  1