Responsive Newsletter-sign-up-form

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  SUGGESTIONS 🟡:

  • The success state is not seen because of the page reloads before the success element is displayed with flexbox

  ---

  • This is due to form submission, you want to add e.preventDefault() method to form submission to prevent the default submitting behaviour

  ---

  • And along with that you can consider to wrap the section element with class of success inside the main element

  ---

  • Because section element can't define the landmark for a site, it can only be used within landmark elements like main

  ---

  • So make sure to nest the section inside main to improve accessibility

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Jonah Ssegawa•240

  @devjhexPosted over 1 year ago

  @0xAbdulKhalid Man thanks for the help it was really helpful.

  0