Skip to content
Submitted 6 months ago

Responsive NewsLetter with JS Validation

Samuel Sylvester•330
@Sylvester009
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Newsletter sign-up form with success message
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

nothing for now

What challenges did you encounter, and how did you overcome them?

none for now

What specific areas of your project would you like help with?

none for now but any suggestions will be appreciated.

Community feedback

  • Boris•2,850
    @mkborisPosted 6 months ago

    Hi @Sylvester009 nice work, here are some suggestions that might be of interest to you.

    • Responsive images are handled using html elements and techniques such as the picture element. Using CSS to hide and show images (when given images to display according to screen sizes) is not part of the best practices.
    • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
    • Media queries should be defined in rem or em not px. Also, I think the large padding on your main is causing the layout to shift earlier than it should. Consider adding a max-width on your main and reducing the side padding then using justify-content: center; on the body to center the component.

    Hope this helps.

    0
    Samuel Sylvester•330
    @Sylvester009Posted 6 months ago

    @mkboris ok, thank you very much

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord