Responsive newsletter using html5,css flexbox and javascript

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 1 year ago

  Hi MD-JAABIR

  I have checked your work and here my findings:

  • Landmark regions provide a powerful way to identify the organization and structure of a web page and are therefore necessary to be included in your site. Landmark regions include the main, footer, header elements. You can find out more on MDN docs on the practical usage of these elements.
  • input elements should be associated with a label , which is used for the benefit of assistive technology users by announcing the presents of the input element. Using semantic elements will go a long way in improving the accessibility of your site.
  • when you are provided with different images to display according to screen size, the recommended methods to use includes the picture element and the srcset . Using CSS to hide and show images is not best practice.
  • another best practice is to have only a single h1 element on a page.
  • the site should be responsive from at least 320px and going upwards. Check your site between 376px and 750px using devtools
  • on the body element , setting the height should be avoided, usually the min-height: 100vh is used on the body so that , there is enough vertical length to allow scrolling.
  • font sizes should not be written in px values, the following article will give you guidance on Why font-size must NEVER be in pixels
  • keep the specificity as low as possible by using classes for styling and avoiding nesting. The following .newsletter .left ul li can be avoided.
  • the display email message should be dynamically be changed using javascript according to the email provided

  Marked as helpful

  1

  ---

  

  Md-Jaabir•350

  @Md-JaabirPosted about 1 year ago

  @ChamuMutezva Many many thanks for your feedback. I will try to follow your guidelines from my next project.

  0