responsive newsletter using flexBox

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 10 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • The input and the button should be enclosed in a <form> tag.

  • "Email Address" should be a <label> tag with a for="emailField" attribute to link it with the input. If a user clicks on this label, the input field with the id="emailField" will be automatically selected.

    <label for="emailField">Email address</label>
    

  • It's interesting that you use localStorage for data submission. As a suggestion, you could have everything on a single screen and toggle visibility if the submission is successful. This way, you can avoid page reloads and the reloading of all styles. You could even use query params to send information like the email.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  1

  ---

  

  JoshBolu•170

  @JoshBoluPosted 10 months ago

  thank you, will start using the correction from now on @MelvinAguilar

  0
• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  Looks great @JoshBolu!

  I see that the default borders of the button are still maintained. To remove them, simply add the button selector to your CSS or you can do it with the id that you assigned to it:

  button {
      border: none;
  }
  

  On the other hand, in media queries you do not need to redefine the properties whose value you are not going to change.

  0

  ---

  

  JoshBolu•170

  @JoshBoluPosted 10 months ago

  Thank you , correction noted@Blackpachamame

  0