Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

responsive newsletter using flexBox

JoshBoluโ€ข 170

@JoshBolu

Desktop design screenshot for the Newsletter sign-up form with success message coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


really took me a lot of time to make this work

Open for Advice that'll prompt improvement.

Community feedback

@MelvinAguilar

Posted

Hello there ๐Ÿ‘‹. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

  • The input and the button should be enclosed in a <form> tag.
  • "Email Address" should be a <label> tag with a for="emailField" attribute to link it with the input. If a user clicks on this label, the input field with the id="emailField" will be automatically selected.

    <label for="emailField">Email address</label>
    
  • It's interesting that you use localStorage for data submission. As a suggestion, you could have everything on a single screen and toggle visibility if the submission is successful. This way, you can avoid page reloads and the reloading of all styles. You could even use query params to send information like the email.

I hope you find it useful! ๐Ÿ˜„ Above all, the solution you submitted is great!

Happy coding!

1

JoshBoluโ€ข 170

@JoshBolu

Posted

thank you, will start using the correction from now on @MelvinAguilar

0
Marcos Travagliniโ€ข 4,920

@Blackpachamame

Posted

Looks great @JoshBolu!

I see that the default borders of the button are still maintained. To remove them, simply add the button selector to your CSS or you can do it with the id that you assigned to it:

button {
    border: none;
}

On the other hand, in media queries you do not need to redefine the properties whose value you are not going to change.

0

JoshBoluโ€ข 170

@JoshBolu

Posted

Thank you , correction noted@Blackpachamame

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord