Responsive Newsletter using flexbox

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 10 months ago

  Hello there 👋. Good job on completing the challenge !

  I have other suggestions about your code that might interest you.

  • Directly manipulating styles in JavaScript can lead to code that is hard to maintain. Create a CSS class with the desired styles and use JavaScript to add or remove that class.

  • Swapping the image can be done in CSS; using JavaScript is overly complicated. Simply use a media query to change the image content.

  I hope you find it useful! 😄

  Happy coding!

  2

  ---

  

  lakshyachitranshs•40

  @lakshyachitranshsPosted 10 months ago

  Thank you so much foryour feedback i will implement you suggestions @MelvinAguilar But how can we change img src from media query ?

  0
• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  Hey, you've done a great job! I loved the animations 😁

  I can only tell you the following:

  • You must add the name attribute to your input so that the label is correctly related to it. In this case it would be name="email"
  • Have you forgotten a console.log that says hello 😅
  • Styles need to be adjusted in the Dismiss message button
  • Is it possible that you haven't imported the font-family of the original design? 🤔

  1

  ---

  

  lakshyachitranshs•40

  @lakshyachitranshsPosted 10 months ago

  Hey @Blackpachamame Yes i forgot the font family thanks man for noticing i will do the change I will add the name attribute And regarding console.log i was testing something i will remove that Thank you so much for your feedback

  1
• 

  Mohamed Mostafa•480

  @MohamedkazafyPosted 10 months ago

  good job bro

  1

  ---

  

  lakshyachitranshs•40

  @lakshyachitranshsPosted 10 months ago

  Thank you @Mohamedkazafy

  0