Responsive newsletter signup page using client-side query parameter

Community feedback

• 

  Alex•3,130

  @Alex-Archer-IPosted 6 months ago

  Hi! You've taken a pretty interesting approach here =)

  And while it is totally fine for practice, if it was real project it'll be a bad user experience - to reload the page just to show up a modal window.

  The better way would be to keep both windows in one html file and change display from block to none via JS.

  Also there could be a couple semantic improvements:

  • Use more semantic tags. Title must be in h1, text - p, list of features - ul, and every page should contain main tag.
  • More important that the input should be inside the form.

  <form>
    <label for="email">Email address</label>
    <input type="email" id="email" name="email" placeholder="[email protected]"required>
    <button>Subscribe to monthly newsletter</button>
  </form>
  

  This will be really important in real projects cos form is necessary to send data to the server. By the same reason input should have a name attribute.

  Oh, and I can give a tip how to improve your regular expression =) Try this. /[-.\w]+@([\w-]+\.)+[-\w]/g It means:

  [-.\w]+ - any combination of letters, dot or hyphen
  @([\w-]+\.)+ - @ symbol followed by any combination of letters, dot or hyphen, followed by dot
  [-\w] - and than again any combination after the dot
  

  That generate email pattern for validation and could make your code shorter =)

  By the way, that's cool that you are use regexps, it's quite powerful tool =)

  Hope something of all this could help =)

  Marked as helpful

  1

  ---

  

  Navroz Singh•220

  @Navroz-SinghPosted 5 months ago

  @Alex-Archer-I Thank you so much for giving your precious time to help me. I will take these recommendations into consideration for my next projects. I am new to webdev so I guess I gotta learn more.

  1

  

  Alex•3,130

  @Alex-Archer-IPosted 5 months ago

  @Navroz-Singh

  Oh, there is always something to learn. Even if you think that you have learned enough and gained experience, just wait until new framework, library or specification pops up.

  I'm not trying to discourage you! Learn is fun =)

  1