Responsive Newsletter sign-up form with success message

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted over 1 year ago

  Hey there,

  It's a really nice-looking solution, well done! Not sure what you mean by saying the hover effect doesn't work properly? If I'm guessing correctly what you mean: hover effects are for laptop/desktop devices, it's expected behaviour that they "don't work" on mobile. :) I have advice though regarding your code:

  • For your own sake (and anyone else working together with you), spend some time coming up with descriptive classnames. item__3 and item__3-1 don't say much and it's especially bothersome to follow the code when looking at the CSS.

  • Decorative images don't need to have alt texts, you can leave them blank.

  • It's good practice to remove console logs before you push your code to Github.

  • Your code should be wrapped in a main element, the main content of your website goes here (there's also header, footer, but that doesn't apply to this, of course).

  • Inputs should be wrapped inside a form and each input come with a label description (here, you're using just a div to achieve this).

  • There's a small typo in the text ("And much more!").

  Other than this, I'd say great job!

  1