Design comparison
Solution retrospective
Hey there ๐
Features ๐ฏ
- Responsive
- Dom (document object model )
- 100% performance on mobile and desktop device
Built with ๐ฅ
- Html and Css
- Javascript
- Sass/ Scss
Your feedback helps me alot to write more clean code so Don't forget to write it ๐
Community feedback
- @petritnurediniPosted 10 months ago
Congratulations on completing your project! ๐ Your effort in building a responsive countdown timer app with React.js and TypeScript is truly commendable. It's great to see that you've implemented a component-based structure and made the app responsive for both mobile and desktop views. ๐ฅ๏ธ๐ฑ
Here are some best practices recommendations to consider:
-
Semantic HTML: Use more semantic elements in your markup where possible. This not only improves accessibility but also helps with SEO and maintainability of your code. For instance, consider using
<button>
instead of<div>
for clickable actions. ๐ง -
CSS Organization: Organize your CSS by splitting it into logical sections and possibly using comments to denote those sections. This will make it easier to navigate and maintain in the long run. ๐
-
Avoid Inline Styles: In your JavaScript, try to avoid setting styles directly on elements. Instead, toggle classes that define these styles. This keeps your presentation and behavior concerns separate. ๐
-
Use
const
andlet
: It's best practice in modern JavaScript to useconst
andlet
for variable declarations instead ofvar
. This provides block-scoped variables, which can help prevent various bugs. ๐ -
Accessibility: Ensure that your app is fully accessible. For example, all interactive elements should be focusable and should have appropriate ARIA labels if their purpose is not clear from the text content alone. ๐
-
Code Formatting: Consider using a code formatter like Prettier or ESLint. This will help you maintain a consistent code style and catch potential issues early. ๐งน
-
Performance: Keep an eye on the performance of your app. Tools like Google's Lighthouse can be used to audit your app and provide insights on how it can be improved. ๐
-
Testing: If you haven't already, start writing tests for your components. This will save you time in the long run and make your app much more reliable. Jest and React Testing Library are great tools to get started with. โ
References:
- For semantic HTML: MDN Web Docs
- For CSS organization: CSS-Tricks
- For accessibility: WebAIM
- For code formatting: Prettier
- For performance: Google Lighthouse
- For testing: Jest, React Testing Library
Keep up the great work, and never stop learning and improving. The world of front-end development is always evolving, and staying up-to-date with best practices will ensure your projects stand out. Remember, every line of code is a step forward in your development journey! ๐ช
0@jeff-mzPosted 10 months agothat was informative but this is another project @petritnuredini
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord