Responsive newsletter sign-up app with html, css and JS
Design comparison
Solution retrospective
Feedback are totally welcomed : )
Community feedback
- Account deleted
Well done! Just a couple of things I noticed. The input on hover creates a border at the left and right. It's a nice touch but it creates some issues like shifting the text and placeholder whenever hovering in and out and with outline looks kind of messy, especially when focus + hovering in and out. Maybe you could do an inner shadow at left and right? Not sure but I definitely believe without this border would look much better. The outline however is perfect. Another idea would be is when hovering to create some lighter outline maybe? You can experiment with lots of things here.
Something else that I found a little weird was the regex for the email validation, which again not exactly an issue but not something you would choose to do that in a real website. Most likely you would want to validate the general email pattern, like <username>@<domain>.<tld>.
But in any case if you did it intentionally then you can ignore everything I said, again well done!
Marked as helpful0@Mahmoudamin11Posted about 1 year ago@arkatsy thank you for your really useful feedback i just didn't understand what you meant to say about thte regex
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord