Responsive Newsletter Sign Up with Success Message

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  JAVASCRIPT 🟡:

  • Looks like the information ERROR: Valid email required is logging at developer console due to the console.log(). it's an issue to have console.log() statements in a finished web application.

  ---

  • This is because console.log() statements are used for debugging purposes, and they are not intended to be seen by users. When console.log() statements are left in a finished web application, they can reveal sensitive information to users, such as the values of variables or the structure of the application's code. This can make the application vulnerable to attack.

  ---

  • So please remove those console.log() statements from the application as soon as possible. then we can completely remove the risk of sensitive information being exposed to users.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  Alejandro Perdomo•750

  @Cavalry2010Posted over 1 year ago

  @0xAbdulKhalid Thank you for your recommendations! I see, that can be a security risk, I removed the console.log() statements from the application.

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @Cavalry2010 Glad you found it helpful ! 🤠

  0
• 

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  ➨ Dismiss Message is not working on thank you card try to fix it.

  I hope you find this helpful.

  Happy coding😄

  0

  ---

  

  Alejandro Perdomo•750

  @Cavalry2010Posted over 1 year ago

  @NehalSahu8055 Hi, thank you for viewing my solution! The challenge didn't specify what behavior the Dismiss Message button should have, so I just made it reload the web application upon clicking it.

  0

  

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  @Cavalry2010

  It would be better if your use dismiss button linking to your main card.

  0