@RanitManik
Posted
Your solution looks legitimate. I have reviewed your code, and here are some suggestions from me:
-
Specify Image Dimensions:
- Always set both the height and width attributes for images. This practice ensures that the space required for the image is reserved when the page loads, preventing layout shifts. Your success page is currently experiencing layout shifts because these attributes are not specified. For more details, refer to this article.
-
Display User Email:
- On the success page, ensure you display the user's previously input email. Currently, the email shown is always
[email protected], which is incorrect.
- On the success page, ensure you display the user's previously input email. Currently, the email shown is always
-
Alt Text for Images:
- Avoid using
alttext for non-decorative images. In this challenge, all images are non-decorative, so you should leave thealtattribute blank, like this:<img src="./assets/image.jpg" alt="">. For more information on this best practice, watch this video.
- Avoid using
- I hope you find my feedback helpful. Please mark it as helpful if you do.
Marked as helpful
@Dipesh-sapkota1
Posted
@RanitManik Thank you for your feedback.I have another question. I've been using vanilla CSS for a while and have a basic understanding of responsive design. I know there's more to learn, but based on my project, should I focus on improving my skills with vanilla CSS, or should I start using frameworks?
@RanitManik
Posted
@Dipesh-sapkota1 I think you should start using CSS frameworks as they are like CSS on steroids. However, under the hood, they are essentially just CSS. I suggest you begin using SCSS/SASS and then transition to Tailwind CSS.
From Your code I think you are more than ready.
