Design comparison
Solution retrospective
I would really appreciate feedbacks on the following:
- Code readability
- Usage of Semantic HTML
- CSS cleanliness and responsiveness
Your feedback will be highly appreciated. Thank you.
Community feedback
- @NehalSahu8055Posted over 1 year ago
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
➨ Don't use two
<main>
as there is only one top-level heading I can see. Always follow the semantics.➨ For future use if by chance you have to use
multiple main
use like this:<main aria-labelledby="title1"> <h1 id="title1">title for main content area 1<h1> .... main content area 1 .... </main> .... <main aria-labelledby="title2"> <h1 id="title2">title for main content area 2<h1> .... main content area 2 .... </main>
I hope you find this helpful.
Happy coding😄
Marked as helpful0@UtopicUnicorn995Posted over 1 year ago@NehalSahu8055 Would it be better to use two articles instead of two mains or should I just replace one of them?
Thank you.
1@NehalSahu8055Posted over 1 year ago@UtopicUnicorn995
Except
<header>
and<footer>
all content goes in<main>
as a rule ofsemantics
.like this :
<header> -------top content like heading , nav , banner------ </header> <main> --------main content------ </main> <footer> --------bottom content like copyright ------ </footer>
0@NehalSahu8055Posted over 1 year ago@UtopicUnicorn995 Your <article> goes in <main> replace 2nd main and replaced one inside <main>
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord