Responsive news-homepage

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 11 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • The <main> element behaves like a main landmark role. Landmarks can be used by assistive technology to quickly identify and navigate to large sections of the document.

  ---

  • Here you just declared role="main" for main element which is already a semantic element by default. Adding explicit role on a semantic element is just like a bloatware for no reason, We can follow up the efficient way which is simply the main element.

  ---

  • So you can refactor the <main role="main"> to <main>

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Dagim Tizazu•240

  @DagimTizazuPosted 11 months ago

  Thanks @0xAbdulKhalid , I just fixed it by adding the role attribute to the hero area container div. I think it makes more sense in this case I guess

  0