Design comparison
SolutionDesign
Solution retrospective
Hello dear community! I am new at programming, this is my very first website without being guided by a tutorial! It was quite a challenge but I feel I learned a lot during this 2 days.
If anyone has some feedback, it would be very appreciated!
Things that I couldn't resolve or were hard to do:
- For some reason I couldn't make the mobile menu to have a transition ease-in-out.
- I am having difficulties with media queries. Any tips?
- I have a big screen, so it was a challenge to make it look good and accurate for all screen sizes.
Thanks you all!
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
.
HTML 🏷️:
- This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to
non-semanticmarkup, which lack landmark for a webpage
- So fix it by replacing the element
<div class="attribution">the with semantic element<footer>in yourindex.htmlfile to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>or<span>
- They convey the structure of your page. For example, The
<footer>typically contains information about the author of the section, copyright data or links to related documents.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord