Responsive News Letter

Community feedback

• 

  Basit Korai•350

  @basitkoraiPosted over 1 year ago

  Hi, my friend. 👋 I'm delighted that you have completed the project

  I have some suggestions to improve your project.

  • I would suggest wrapping this entire component in an <article> tag for better accessibility.
  • For the main hero image, I would suggest going for the <picture> tag instead of this <figure>, it'll also help with automatically choosing the right image at the right viewport.
  • Set min-height: 100vh; to the <main> element for centering everything.
  • Also Update your background-color.

  Upvote the comment if it helps

  I hope these tips will help you improve your code.😊

  Happy Coding✌️

  Marked as helpful

  0

  ---

  

  Abieb_Guardian•200

  @AbibGuardian50Posted over 1 year ago

  @basit-flash thanks for your feedback, i will apply it soon

  0