Design comparison
SolutionDesign
Solution retrospective
positive feedback please :D
Community feedback
- @alfiemitchell123Posted over 1 year ago
This looks great and responds well when you resize the browser. I only noticed a couple of minor issues with your solution -
- On the mobile site, the menu toggle icon shows the sidebar and the close icon is displayed. When you do this for a second time, the close icon is no longer shown, and you are unable to close out of the sidebar. I had a look over your code, and I'm not sure exactly what the root of the issue is. I've attached a screen recording below (via WeTransfer) to show this.
- The second regards your coding structure. I would recommend separating your CSS and JS from your HTML by writing these languages in their own files and referencing them in the HTML document. This makes it a lot easier for anyone to read and debug your code.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord