@VCarames
Posted
@Master786-wd
Hey there! 👋 Here are some suggestions to help improve your code:
- The logo should be outside the
nav
.
- The logo’s
alt tag
description needs to be improved upon ⚠️; it should ALWAYS and only state the company’s name.
- Nav menus are not created in that manner; there is no need for separate code for the "mobile" and "desktop". Ps. Why did you use a
anchor
element to create thenav
button (it doesn't direct user anywhere)?
- Create a single
nav
and inside have abutton
and it should have anaria-label
,aria-expanded
andaria-control
. After the button, add theunordered list
containing the links.
- You will then use
CSS
to then style the nav for mobile and desktop.
- "Overlays" are not created in this manner;
<div id="overlay"></div>
. To create it, you will useposition
and have it applied/removed to thebody
when the nav menu opens/close.
- There is still a lot more that needs to fix, but this will suffice for now.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 👾
@Master786-wd
Posted
@VCarames Thank you for your feedback. I will use those suggestions in the future.