responsive news homepage using Flex-box and Grid

Community feedback

• 

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted about 2 years ago

  But next time your close button should be in the same div of the nav-links

  E.g

  `` 1. <button>btn</button>

  2. <li> links</li>
  3. <li> links</li>
  4. <li> links</li> ``

  This prevent the close button from scrolling outside of view.

  besides you did really great👍

  0
• 

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted about 2 years ago

  Hi there👍...I think you really did a great Job there..keep it up.. 👍

  1. On the navigation on mobile, the height is not covering the entire vertical screen on mobile when opened. always use 100vh which is 100% a devices viewport height instead of just using height:100%.

  Besides you did a very great job.👍 Happy Coding👍

  0

  ---

  

  P

  Kellen Ruyle•930

  @rule-kellsPosted about 2 years ago

  @Kamasah-Dickson Hey! thanks for the feedback. Yeah, I noticed that too. I have the navigation set to 100vh but for some reason doesn't work properly. If you have any suggestions, I would appreciate it.

  0

  

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted about 2 years ago

  @rule-kells try position fixed and see, sometimes it works

  1

  

  P

  Kellen Ruyle•930

  @rule-kellsPosted about 2 years ago

  @Kamasah-Dickson yep that worked! thanks!

  0

  

  Kamasah-Dickson•5,590

  @Kamasah-DicksonPosted about 2 years ago

  @rule-kells you are very welcome👍

  0