Kyrie• 70
@KyrieeWen
Posted
Hey MIHAIL, I reviewed your code, and think would be helpful to give you some feedback
App.js,
- You can store those dummy data to another file called data.js for example to leave the functional component space cleaner..
- Good job to use nav to improve accessibility 3.navItems.map can be refactored to change i to item to make it more readable
- Consider to use BEM css name convention to name classes, nice to have 5.I would suggest to import image as xxx, then src={xxx}, in your case, each time when it re rendered, it needs to require those two images again 6.Change art to article to be more descriptive
- remove empty space on line 95, 97
App.scss
- Good to use config file and store css variables to reuse
- would be good to seperate css and scss file, and store compiled css file to other folder
- Good to use vw and rem
Let me know if there any specific question you want to ask me , happy to answer!.
Hope it would be helpful
Marked as helpful
0
Mihail• 160
@mihail-soltan
Posted
@KyrieeWen Hi Kyrie! Thank you so much for the feedback and suggestions! I'll make sure to apply the changes asap :)
0