Responsive Multi-Step From using Angular

Community feedback

• 

  Pavel B.•270

  @JagholinPosted over 1 year ago

  Styling is more or less fine, some things are misaligned. Phone number input field doesnt accept spaces, even though the placeholder text suggests that it should.

  "Next step" button for some reason has different styles on different pages. Sometimes it has cursor: pointer, sometimes doesnt.

  Next step is not a <button>, "go back" is neither a link nor a button. The second page has 0 interactive elements, according to accessibility tool in DevTools

  Dont use heading tags <h1>, <h2> etc. for styling, as they have special meaning for accessibility tools. Each page should have exactly one <h1> element. Skipping heading levels is unadvisable.

  Marked as helpful

  1

  ---

  

  Jesus Eiseel Pena Ceballo•190

  @ChuchyXPosted over 1 year ago

  @Jagholin Thank you very much for your feedback. Very good recommendations, I will try to fix it immediately

  0
• 

  Lucas Nahuel Muñoz•170

  @LucasNahuelPosted over 1 year ago

  In your code, when you select a plan, it adds up to the total. So if you go to the 2nd step, change it, and then go to the 4th step, the total adds up and now shows the anterior plan price plus the new selected one. Make sure when you select a new plan you clear the total and assign the new value.

  Another more general thing, would be better if you componetize the different steps and elements of the form, and having a programatic structure that stores the differents plans/addons info (like an array) instead of hard-coding them over the program.

  greetings 👋

  Marked as helpful

  0

  ---

  

  Jesus Eiseel Pena Ceballo•190

  @ChuchyXPosted over 1 year ago

  @LucasNahuel Thank you very much for your feedback. Very good recommendations, I will try to fix it immediately

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <app-root> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • You already using Flexbox for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.

  ---

  @media (min-width: 767px) {
     .mayor-container {
       align-items: center;
     }
  }
  

  • Now remove these styles, after removing you can able to see the changes

  @media (min-width: 767px) {
     .mayor-container {
       padding-top: 50px;
     }
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Jesus Eiseel Pena Ceballo•190

  @ChuchyXPosted over 1 year ago

  @0xAbdulKhalid Thank you very much for your feedback. Very good recommendations, I will try to fix it immediately

  0