Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

responsive multipage website with html css pug sass js

@moustafasa

Desktop design screenshot for the Space tourism multi-page website coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


i am a beginner so what your oponions and can you help me to improve the performance of that website?

Community feedback

T
Chamu 13,110

@ChamuMutezva

Posted

Hi Moustafa saad

You did a great job with the challenge, well done. The site is responsive

  • the hamburger menu should be an interactive element, a div element should not be used for interactive purposes(it will not be responsive to assistive technology users) - in this case a button will be relevant in my opinion.
  • The heading element can be improved , space alone , appear not be meaningful enough for me. According to MDN Docs an h1 element - should concisely describe the overall purpose of the content. This should have been the whole Heading h1 element so, you want to travel to space
  • if it is a button , then it should be a button <div class="main-btn f-600">explore</div>. For the same reasons mentioned in the hamburger menu
  • <img src="" alt=""> , the src is mandatory , it cannot be empty
  • your list of tabs should have an interactive element as a child which can be an anchor element as the purpose here is to navigate to another section as in this particular instance.

Happy coding

Marked as helpful

1

@moustafasa

Posted

@ChamuMutezva thanks a lot for your advices it is really helpful i will work on it

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord