responsive multipage website with html css pug sass js

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 2 years ago

  Hi Moustafa saad

  You did a great job with the challenge, well done. The site is responsive

  • the hamburger menu should be an interactive element, a div element should not be used for interactive purposes(it will not be responsive to assistive technology users) - in this case a button will be relevant in my opinion.
  • The heading element can be improved , space alone , appear not be meaningful enough for me. According to MDN Docs an h1 element - should concisely describe the overall purpose of the content. This should have been the whole Heading h1 element so, you want to travel to space
  • if it is a button , then it should be a button <div class="main-btn f-600">explore</div>. For the same reasons mentioned in the hamburger menu
  • <img src="" alt=""> , the src is mandatory , it cannot be empty
  • your list of tabs should have an interactive element as a child which can be an anchor element as the purpose here is to navigate to another section as in this particular instance.

  Happy coding

  Marked as helpful

  1

  ---

  

  moustafa saad•190

  @moustafasaPosted about 2 years ago

  @ChamuMutezva thanks a lot for your advices it is really helpful i will work on it

  0