Skip to content
Submitted over 2 years ago

Responsive multi-page website using HTML, Sass/CSS, JS

Marija•80
@Marija-Kov
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Space tourism multi-page website
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Solution retrospective

Took upon this challenge as I was getting deeper into (vanilla) JS so naturally I enjoyed flexing my JS skills by creating as many elements as I could dynamically and organizing my code into modules. I was wondering if there was a significantly better practice (in plain JS) than what I've done in this project to display content using async functions and fetch-then chain in each of my .js files (destination.js, crew.js, technology.js in 'starter-code' folder -- apologies for not sensibly organizing all these files into separate folders). Thanks.

Community feedback

  • Vander Santos•1,750
    @vandermsPosted over 2 years ago

    Well done!

    Your solution is very good and I loved it! My only tips are:

    1. A extension like prettier (or other code formatter) could improve the readability of your code. Sometimes, I found the identation of your js solution hard to read.

    2. Considering the risk of XSS atack, I wouldn't recommend using innerHTML, especially when the data is coming from the server. I probably didn't see all uses of innerHTML, but the cases that I saw you could replace it with the safer options innerText or textContent and the result would be the same.

    3. And your solution would be indeed more easy to understand if you had organized the files inside folders.

    Keep up the good work!

    Marked as helpful
    1
    Marija•80
    @Marija-KovPosted over 2 years ago

    @vanderms Thanks a lot for the kind words and great tips!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord