Responsive Multi-page Website using CSS-Grid, JQuery, utility classes

Community feedback

• 

  hidayahmsabah•160

  @hidayahmsabahPosted almost 3 years ago

  Hi Aperlae,

  Good job overall on the whole site! This is just some preliminary debug I did from looking at your code snippets which you can correct me if you've done that but the issue still persists.

  1. I notice the bg inconsistency happens when you're in tablet/mobile view so my guess it's because the page itself is inconsistent in terms of height due to scroll function. You can try specifying a height for that particular page, maybe make it consistent across all pages that it be at 100vh, or the other one, which I'm not sure would work, is specifying background-size: cover.

  2. On the index.html page you have no elements that can be query selected using '[role="tablist"] so it returns a null. That's why dev tools flagged that as an error because in line 18 of your index.js, you were referring to those elements which are null. Can simply add a conditional before that specific line to remove it the error.

  Marked as helpful

  0

  ---

  

  Aperlae•80

  @AperlaePosted almost 3 years ago

  @hidayahmsabah thank you so much, setting the viewport height on the destination container worked like a treat :smiley: Still trying to figure out the second point but I'll get there!

  0