Design comparison
Solution retrospective
I lack of JavaScript Basics, and it was a real challenge do get it through. I know I can do better in code point of vue. I would be glad to get some reviews.
Community feedback
- @ndragun92Posted over 1 year ago
Hello,
Great job! Congratz on finishing the challenge
I want to point few things here. I have seen your SubscriptionForm.vue and since this is a multi-step form and uses v-if/else conditions that means that some of the components do not need to be present there on the initial page load.
Instead of importing them like
import Step2 from "./SubscriptionParts/Step2.vue";
you can lazy load them to boost performanceconst Step2 = defineAsyncComponent(() => import('./SubscriptionParts/Step2.vue') )
Also, v-for should not use the index as a key (this is least recommended). Use the name or something unique if it is unique if not you can mix the title and index like
:key="`${plan.name}--${index}`"
v-for="(plan, index) in plans" :key="index"
Another thing regarding click/change events. I have seen that you mix v-on:click and @change I would recommend using the same syntax in code such as @click and @change to make it a bit better.
UI related forms could be centered in the middle of the screen
Overall good job! Keep it up!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord