Design comparison
Solution retrospective
I was quite nervous to start this challenge due to me being new, but I have to say it was really fun and quite the challenge. any feed back and tips would be appreciated :) I know my code is a lil messy, go easy on me haha i'm still new to all this
Community feedback
- @FluffyKasPosted about 3 years ago
It's a great looking solution if you ask me, well done! ^^ I'd only add that you could perhaps fix the social links as they're currently not links, only images. Wrap them in <a> tags and give them an aria-label (instead of the alt which is not needed here) and you're good to go.
As an extra note, I'll link this article about alt texts. It's nice that you haven't forgotten about them but they could be improved a bit. (https://axesslab.com/alt-texts/)
Marked as helpful1@riqydevPosted about 3 years ago@FluffyKas Ohh, I had totally forgotten about that, tysm!
I just checked out that article and it helped me quite a lot, I really appreciate the tip. Will keep that stuff in mind going forward :) have a good rest of your day!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord