Responsive Mobile-first qr code component - html+css only

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container__disp"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  There is no need to give h1 and p font weight values, there is no need for a margin-top value in .container-text, replace the padding in .container_text with margin. Add a font-size of 0.9375em to .container_text, this will be the font-size of both h1 and p.

  Replace the height in .card with a padding value for all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement. padding: 1em;

  This challenge does not require a box-shadow, there is no need to style .container_qrcode. Give .qr-code a max-width of 100% instead of a width and height and border-radius value, the rest are not needed.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0
• 

  EmanueleMicali•60

  @EmanueleMicaliPosted almost 2 years ago

  Hey jrlampa.

  Before submitting, you can click the link that says "Not sure how to submit? Read our complete guide to submitting solutions." which will send you to this: https://medium.com/frontend-mentor/a-complete-guide-to-submitting-solutions-on-frontend-mentor-ac6384162248

  It's a step-by-step tutorial on how to submit that I used yesterday when I started on the website.

  Hope it helped! -Emanuele

  Marked as helpful

  0