responsive (mobile version made first, then responsive for web)
Design comparison
Community feedback
- @faha1999Posted about 2 years ago
Hello, Szabolcs Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:
- remove the below code to the body. It will center everything
body { /*width: 90%; */ /* margin: auto; */ }
-
remove
margin
frommain
-
Instead of using
px
, use relative units likerem or em
to get better performance when the information on your page needs to be resized for multiple screens and devices.REM
andEM
apply to all sizes, not justfont-size
. You can code your entire page inpx
and then, at the very end, use the VsCode pluginpx to rem
to perform the automatic conversion px to rem
I hope it will work. Happy coding.
Marked as helpful1@BielCoelhoPosted about 2 years ago@faha1999 i have small stuggle using rem, but i'm trying to get used to
btw if i remove margin: auto from body, it un-center things i removed from main, it was a leftover I forgot before adding other styles to center
thanks for the feedback man, ill use rem/em in next project
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord