Responsive mobile first testimonial section using Grid

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Christian, Congratulations on completing this challenge!

  Great code and great solution! I did this challenge too and know how much is hard to setup this grid layout. I think you've done a really good working building everything! Here's some tips for you:

  You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the quote text you can improve the accessibility there using <blockquote> to indicate to screen readers that the content inside that paragraph is a quote.I saw that for some properties you’ve used rem and for others px. In this case it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em that have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Christian Prasetya•370

  @christian-prasetyaPosted about 2 years ago

  @correlucas Wow, thank you for the feedback, really appreciate so much. I'll keep in mind for my future challenge.

  0