Responsive mobile first password generator app with SASS.

Community feedback

• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. When it comes to centering a div or any element on a webpage, using margins may not always be the best approach. so use flexbox or grid layout for centering the div.

  Here's an example code snippet:

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  now remove these styles
  .container {
  margin: 0 auto;
  }
  

  Marked as helpful

  1

  ---

  

  José Antonio•50

  @antoniosotopwrPosted over 1 year ago

  Hello @Kamlesh0007 , thanks for your words and feedback, I really appreciate it! I will try your suggestion. Cheers!

  0