Responsive meet landing page

Community feedback

• 

  Davide•1,725

  @Da-vi-dePosted over 3 years ago

  Hi, it's a nice result for this challenge, full responsive! The html is not all correct.

  • The <section> </section> element is misused, the only correct use is where you have these classes class="text-wrapper mobile-text".

  • The headings: they should appear in order from h1 to h6, decreased by one, which means the h1 it must appear only once and that's it, you can't use it again, let's say in your <footer> </footer> element! It doesn't mean the page must start from h1 it depends on the layout, you can start with h2 but what matters it's coherence!

  • The <picture></picture> element: I saw you used it three times in a row with an <image> tag inside each one of them, it doesn't make really sense, you just need one element in which you can use another element called <source> and put the images for tablet and desktop in there, you just need the attributes media and srcset like so:

  <picture>
  <source media="(min-width: ...)" srcset="your desktop image">
  <source media="(min-width: ...)" srcset="your tablet image">
  <img src="your mobile image goes here, it's the default image"
            alt="something about the image"
            class="for styling"
  >
  </picture>
  

  This is the only purpose for using that element, when you need to put just an image you don't need to use it, the <img> tag does the job!

  Hope it helps a little, keep coding.

  Marked as helpful

  0
• 

  Emir Muharemagic•175

  @MuharemagiCPosted over 3 years ago

  Thank you for feedback it's mean a lot for me to understand better and improve my programming skills thanks one more time. :D

  1