@elaineleung
Posted
Hi Amaefula Joel, great job here, this was very well done! The site looks great on mobile and desktop views, and things look fairly clean and orderly. It's a good thing that you built this in sections, as that would allow you to focus on each part well.
In general I'd probably give the sections a bit more top and bottom padding, as you can see in the design. The slider was also an interesting element here; if I hadn't seen Kevin Powell's tutorial, I probably would not know this is a slider. Anyway, I think in a real life project you may want to look into how to make an accessible slider instead (as in, one that can be used with the tab key) because it's often considered not a good idea to have an auto scroll slider for screen reader users.
Awesome job on the whole! š
Marked as helpful
@Amaefula-Joel
Posted
@elaineleung thanks a lot. I know how to make a simple slider, but making a slider that would slide on swipe has been a challenge. I'll try to look up Kevin Powell's tutorial, but on what platform is the tutorial?
@elaineleung
Posted
@Amaefula-Joel It's on YouTube, right here: https://youtube.com/playlist?list=PL4-IK0AVhVjNDRHoXGort7sDWcna8cGPA
He just realized the latest one on this series, and it's where he works on his slider, so you might want to have a look!
