Responsive LP, using Flex box CSS

Community feedback

• 

  Joachim•840

  @Thewatcher13Posted over 1 year ago

  Hi,

  Good to see the approach of landmark roles in your html, a few things;

  html

  • You can never ever have more then one H1 heading
  • heading h3 is not correct placed, 76 of 100 should be one p, if I delete the css, the 76 is a seperate line, which makes no sense to the user
  • You should use an ul for the right section
  • Your button should have a type attribute (type=button) by default is is type submit
  • Be carefull with the use of section

  css

  • Use a css reset, look on Andy's bell his website for a good and clear one
  • Never ever set font-sizes in absolute values (px), but in relative (rem) https://fedmentor.dev/posts/font-size-px/
  • Work mobile first, use media queries for tablet and desktop design

  Marked as helpful

  1