Responsive Loopstudios Landing page with HTML,CSS and javaScript
Design comparison
Solution retrospective
Hello, Everyone. This is my submission for this challenge which I really had fun coding. I added a little hover effect on the desktop images and also the navs. I will appreciate a kind review from you all. Please tell me what I could have done to better it. Thank You.
Community feedback
- @DavidMorgadePosted about 2 years ago
Hello Olaitan, great job finishing the challenge! you did a great work in your solution
If you don't mind, I would like to give you some feedback:
-
There is at some range of the page that is getting broke, from like 600px to 1000px, your
div
with the classcontent-1
overlays a bit the page, what you can do as a fast fix is to increase the media querie pixels so it changes the styles later, you should try to maybe adapt a bit the styles but setting the media a bit higher on pixels will fix the issue for now. -
Apart from that your CSS is very good! I like the on hover effects on the images!.
-
The html is totally build out with
divs
! try using more semantically tags likeheader
,main
(divided insections
andarticles
), and also afooter
, the html is a very important part of your webpage, it will determine the accesibility and the position on search engines, if you don't have a semantic html the search engines will penalize you and get your page as the latest results on search, go for those html tags man! they are easy to learn and you will get use with them in no time.
Hope my feedback helped you, if you have any questions, don't hesitate to ask!
Marked as helpful1@Olaitan01Posted about 2 years ago@DavidMorgade OMG! Thank you so much. I did not know all of these. I will do the quick fix with your tips. This is more than helpful.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord